don't show Failed pods

these are not alive, and Scope generally only shows the living, not the dead.
weaveworks · Apr 2, 2018 · feae4f4 · feae4f4
1 parent 27fb357
commit feae4f4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/probe/kubernetes/pod.go b/probe/kubernetes/pod.go
@@ -16,7 +16,10 @@ const (
 )
 
 // Pod states we handle specially
-const StateDeleted = "deleted"
+const (
+	StateDeleted = "deleted"
+	StateFailed  = "Failed"
+)
 
 // Pod represents a Kubernetes pod
 type Pod interface {

diff --git a/render/pod.go b/render/pod.go
@@ -46,7 +46,7 @@ var PodRenderer = Memoise(ConditionalRenderer(renderKubernetesTopologies,
 	MakeFilter(
 		func(n report.Node) bool {
 			state, ok := n.Latest.Lookup(kubernetes.State)
-			return (!ok || state != kubernetes.StateDeleted)
+			return !ok || !(state == kubernetes.StateDeleted || state == kubernetes.StateFailed)
 		},
 		MakeReduce(
 			PropagateSingleMetrics(report.Container,