Skip to content

Commit

Permalink
remove Node.Edges
Browse files Browse the repository at this point in the history
It is unused and none of the adjacency mapping code in the renderer
takes any notice of it. Removing this shrinks the report size.

Edges were introduced in #838. At the time we had an experimental
packet sniffer under experimental/sniff/sniffer.go. That got removed
in #1646.

We can resurrect this if we ever decide to add meta data to edges.
  • Loading branch information
rade committed Dec 17, 2017
1 parent d428b69 commit e93b69c
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 592 deletions.
2 changes: 1 addition & 1 deletion probe/endpoint/connection_tracker.go
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ func (t *connectionTracker) addConnection(rpt *report.Report, incoming bool, ft
fromNode = t.makeEndpointNode(namespaceID, ft.fromAddr, ft.fromPort, extraFromNode)
toNode = t.makeEndpointNode(namespaceID, ft.toAddr, ft.toPort, extraToNode)
)
rpt.Endpoint = rpt.Endpoint.AddNode(fromNode.WithEdge(toNode.ID, report.EdgeMetadata{}))
rpt.Endpoint = rpt.Endpoint.AddNode(fromNode.WithAdjacent(toNode.ID))
rpt.Endpoint = rpt.Endpoint.AddNode(toNode)
}

Expand Down
246 changes: 0 additions & 246 deletions report/edge_metadatas.go

This file was deleted.

Loading

0 comments on commit e93b69c

Please sign in to comment.