Correctly resolve app ids, fixes #825

weaveworks · Feb 5, 2016 · b758d56 · b758d56
1 parent 7dd2292
commit b758d56
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/probe/appclient/app_client.go b/probe/appclient/app_client.go
@@ -192,7 +192,6 @@ func (c *appClient) controlConnection() (bool, error) {
 		return false, err
 	}
 	defer func() {
-		log.Printf("Closing control connection to %s", c.target)
 		conn.Close()
 	}()
 

diff --git a/probe/appclient/multi_client.go b/probe/appclient/multi_client.go
@@ -72,6 +72,7 @@ func (c *multiClient) Set(hostname string, endpoints []string) {
 		go func(endpoint string) {
 			c.sema.acquire()
 			defer c.sema.release()
+			defer wg.Done()
 
 			client, err := c.clientFactory(hostname, endpoint)
 			if err != nil {
@@ -82,10 +83,10 @@ func (c *multiClient) Set(hostname string, endpoints []string) {
 			details, err := client.Details()
 			if err != nil {
 				log.Printf("Error fetching app details: %v", err)
+				return
 			}
 
 			clients <- clientTuple{details, client}
-			wg.Done()
 		}(endpoint)
 	}