fix bug: Counters.DeepEqual handling of nil maps

a nil psMap was considered unequal to an empty psMap
weaveworks · May 29, 2017 · 6523664 · 6523664
1 parent bdfba29
commit 6523664
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/report/counters.go b/report/counters.go
@@ -115,14 +115,11 @@ func (c Counters) String() string {
 
 // DeepEqual tests equality with other Counters
 func (c Counters) DeepEqual(d Counters) bool {
-	if (c.psMap == nil) != (d.psMap == nil) {
+	if c.Size() != d.Size() {
 		return false
-	} else if c.psMap == nil && d.psMap == nil {
-		return true
 	}
-
-	if c.psMap.Size() != d.psMap.Size() {
-		return false
+	if c.Size() == 0 {
+		return true
 	}
 
 	equal := true