Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing auto interval properties in Template #398

Merged
merged 2 commits into from
Sep 30, 2021

Conversation

locan11
Copy link
Contributor

@locan11 locan11 commented Sep 22, 2021

For the Template class, when the template type is interval is selected, the auto properties are missing.

What does this do?

Why is it a good idea?

Context

Questions

Copy link
Collaborator

@JamesGibo JamesGibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution
Looks good to me, please could you move the line in the changelog up to the unreleased version?

@JamesGibo
Copy link
Collaborator

Just a couple of linting errors to fix as well
grafanalib/core.py:261:1: E302 expected 2 blank lines, found 1
grafanalib/core.py:773:1: W293 blank line contains whitespace

@JamesGibo
Copy link
Collaborator

Will fix linting errors in separate PR

@JamesGibo JamesGibo merged commit ad4500f into weaveworks:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants