Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'tox' to run tests #108

Merged
merged 5 commits into from
Feb 19, 2018
Merged

Use 'tox' to run tests #108

merged 5 commits into from
Feb 19, 2018

Conversation

jml
Copy link
Contributor

@jml jml commented Jan 18, 2018

Allows for testing multiple Pythons.

  • make sure tests pass
  • update changelog
  • use six

Builds on #107

@jml jml changed the title WIP: Use 'tox' to run tests Use 'tox' to run tests Feb 19, 2018
test: $(VIRTUALENV_BIN)/py.test
$(VIRTUALENV_BIN)/py.test --junitxml=$(JUNIT_XML)
test: .ensure-tox
$(TOX) --skip-missing-interpreters

This comment was marked as abuse.

This comment was marked as abuse.

@leth
Copy link
Contributor

leth commented Feb 19, 2018

Regarding six: I suggest you vendor it into the project, rather than adding it as dependency.
The whole world tends to depend on six, which creates a version constraint satisfication nightmare.

@jml
Copy link
Contributor Author

jml commented Feb 19, 2018

Thanks! We don't yet need six (according to our tests), so I'm skipping that for now.

@jml jml merged commit d5151b7 into master Feb 19, 2018
@jml jml deleted the python-2-followups branch February 19, 2018 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants