This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Check git repo is writable before proceeding #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our "gitsync" mechanism relies on being able to push a tag back to the upstream repository. But in the daemon, we consider it ready to go once we've managed to clone the repository. This results in confusing errors: if the repo is read-only (either because the deploy key is, or because it's an `https` URL) then syncing will succeed in effect, but report problems. This commit adds a check that we can write to the upstream repo, before considering the daemon ready to go. The check is that we can push an otherwise-meaningless tag (then delete it) -- this being a fairly innocuous write operation.
While starting up, the daemon continually checks whether it can clone the upstream repo, and if so, whether it can write to it. If this results in an error, it stores this away and keeps trying. Until it succeeds, when asked to do anything related to the git repo (i.e., almost anything), it responds with the stored error. In that interim, it's possible that a user will ask for something that needs a cloned repo; and if so, a helpful error is .. helpful.
squaremo
changed the title
samb1729
approved these changes
Dec 10, 2017
| @@ -16,6 +16,7 @@ import ( | |||
|
|
|||
| const ( | |||
| DefaultCloneTimeout = 2 * time.Minute | |||
| CheckPushTag = "flux-write-check" | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our "gitsync" mechanism relies on being able to push a tag back to the
upstream repository. But in the daemon, we consider it ready to go
once we've managed to clone the repository. This results in confusing
errors: if the repo is read-only (either because the deploy key is, or
because it's an
httpsURL) then syncing will succeed in effect, butreport problems.
This commit adds a check that we can write to the upstream repo,
before considering the daemon ready to go. The check is that we can
push an otherwise-meaningless tag (then delete it) -- this being a
fairly innocuous write operation.
I have made this generate a "helpful error" (i.e., with extended help text), so that it will be returned to
fluxctlif the daemon has not got past cloning the repo.