Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Include more repository status details in the /status response. #864

Closed
foot opened this issue Dec 4, 2017 · 6 comments
Closed

Include more repository status details in the /status response. #864

foot opened this issue Dec 4, 2017 · 6 comments
Labels
onboarding/activation Particular pertinence to getting Flux up and running review Issues that need a review

Comments

@foot
Copy link

foot commented Dec 4, 2017

Currently we have configured: true|false.

It would be really cool to be able to show that we've detected a repository at the URL you've provided, but cannot read/write it with the keys we have.

We could then give the user more hints about what they should be doing next in the configuration process.

found: true|false could work?

  • found: false, configured: false: check your repo addr
  • found: true, configured: false: check your permissions
  • configured: true: happy days!

WDYT?

@foot foot added the onboarding/activation Particular pertinence to getting Flux up and running label Dec 4, 2017
@foot
Copy link
Author

foot commented Dec 4, 2017

UI thought: Interpretation of :error should change from RED to YELLOW perhaps too. We use it for "cloning repo..." and other stuff.

@squaremo
Copy link
Member

squaremo commented Dec 4, 2017

A bit of implementation detail ... the /status API in the service uses two RPCs to the daemon:

  • GitRepoConfig, which reports the {URL, branch, path} triple and the public key (potentially generating the latter); then, provided that succeeds,
  • SyncStatus, which is taken as an indication of whether the git repo has been cloned and thereby everything is cool -- if that doesn't return an error, configured is set to true.

We can include more information in the first call, like whether the git repo in question has been cloned, and is writable (given #865). Enough so that the second call will be redundant, except for backward-compatibility.

@foot
Copy link
Author

foot commented Dec 5, 2017

In conclusion!: We can't really differentiate between "does it exist" and "do we have access". Read vs. Write in the error message is a nice addition from #865 though.

@foot foot closed this as completed Dec 5, 2017
@foot
Copy link
Author

foot commented Dec 5, 2017

Would still be useful to report whether we can write to the repo and if we've been able to clone it!

@foot foot reopened this Dec 5, 2017
@squaremo squaremo added the review Issues that need a review label Jun 5, 2018
@squaremo
Copy link
Member

squaremo commented Jun 5, 2018

@foot I think we do report more on the specific repo status now, can you check when you have a sec, and close if it's satisfactory...

@foot
Copy link
Author

foot commented Jun 5, 2018

Yep, the newer API responses here let us see write/cloned. 👌

@foot foot closed this as completed Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
onboarding/activation Particular pertinence to getting Flux up and running review Issues that need a review
Projects
None yet
Development

No branches or pull requests

3 participants