Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup deploy to wordpress.org action #63

Merged
merged 4 commits into from
Dec 4, 2019
Merged

Setup deploy to wordpress.org action #63

merged 4 commits into from
Dec 4, 2019

Conversation

grappler
Copy link
Contributor

@grappler grappler requested a review from ocean90 November 21, 2019 10:31
@grappler
Copy link
Contributor Author

Once wearerequired/coding-standards#36 is merged travis should pass.

@@ -9,6 +9,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- name: Build
run: composer install --prefer-dist --no-dev --optimize-autoloader
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that composer is available here. Probably needs https://github.com/pxgamer/composer-action.

For testing, can we run this on each commit to push it to trunk? Or on schedule?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. How can we test this without it committing to wp.org?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it only commits to trunk we should be okay I think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the changes. I did a small test with https://github.com/wearerequired/wp-team-list/pull/63/checks?check_run_id=320778019 to see if the composer action works. The 10up action only works with tags and I could not see a way to test it.

I don't see any reason why it should not work.

@grappler grappler merged commit 3216103 into master Dec 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the wporg-deploy branch December 4, 2019 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants