-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup deploy to wordpress.org action #63
Conversation
Once wearerequired/coding-standards#36 is merged travis should pass. |
.github/workflows/push-deploy.yml
Outdated
@@ -9,6 +9,8 @@ jobs: | |||
runs-on: ubuntu-latest | |||
steps: | |||
- uses: actions/checkout@master | |||
- name: Build | |||
run: composer install --prefer-dist --no-dev --optimize-autoloader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that composer is available here. Probably needs https://github.com/pxgamer/composer-action.
For testing, can we run this on each commit to push it to trunk? Or on schedule?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. How can we test this without it committing to wp.org?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it only commits to trunk we should be okay I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made the changes. I did a small test with https://github.com/wearerequired/wp-team-list/pull/63/checks?check_run_id=320778019 to see if the composer action works. The 10up action only works with tags and I could not see a way to test it.
I don't see any reason why it should not work.
ef32183
to
6c9c768
Compare
Based on https://github.com/10up/restricted-site-access/blob/develop/.github/workflows/push-deploy.yml