Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup, add PHP file support #270

Merged
merged 21 commits into from
May 16, 2024
Merged

Cleanup, add PHP file support #270

merged 21 commits into from
May 16, 2024

Conversation

swissspidy
Copy link
Collaborator

@swissspidy swissspidy commented May 15, 2024

Description

  • Require PHP 7.4
  • Requires GlotPress 4.0
  • Add support for PHP translation files
  • Improve tests & logic for webhook handlers
  • Improve code quality, enforcing PHPStan level 9
  • Verify SHA 256 signatures for GitHub webhooks instead of SHA1
  • Fixes Behat code coverage configuration

Fixes #237
Fixes #256
Fixes #257
Fixes #241
Fixes #123

How has this been tested?

Unit tests all pass.

Screenshots

N/A

Types of changes

Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.

@swissspidy

This comment was marked as resolved.

@ocean90 ocean90 added this to the 4.0.0 milestone May 16, 2024
@swissspidy
Copy link
Collaborator Author

Some PHPStan improvements incoming

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 71.28713% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 72.45%. Comparing base (a9faec1) to head (542f140).
Report is 1 commits behind head on master.

Files Patch % Lines
inc/Plugin.php 36.36% 7 Missing ⚠️
inc/CLI/LanguagePackCommand.php 0.00% 4 Missing ⚠️
inc/CLI/ProjectCommand.php 40.00% 3 Missing ⚠️
inc/Loader/Git.php 0.00% 3 Missing ⚠️
inc/Loader/Mercurial.php 0.00% 3 Missing ⚠️
inc/Loader/Subversion.php 0.00% 3 Missing ⚠️
inc/ZipProvider.php 66.66% 2 Missing ⚠️
inc/Export.php 93.33% 1 Missing ⚠️
inc/Runner.php 50.00% 1 Missing ⚠️
inc/WebhookHandler/GitHub.php 92.85% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #270      +/-   ##
============================================
- Coverage     81.21%   72.45%   -8.76%     
+ Complexity      369      350      -19     
============================================
  Files            24       29       +5     
  Lines           942     1267     +325     
============================================
+ Hits            765      918     +153     
- Misses          177      349     +172     
Flag Coverage Δ
feature 13.57% <11.88%> (∅)
php 79.76% <72.22%> (-1.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swissspidy swissspidy added [Type] Enhancement New functionality [Component] CLI CLI commands and tooling [Component] Tests Focus on automated testing labels May 16, 2024
@swissspidy swissspidy requested a review from ocean90 May 16, 2024 13:05
inc/ProjectLocator.php Outdated Show resolved Hide resolved
inc/WebhookHandler/Bitbucket.php Outdated Show resolved Hide resolved
@swissspidy swissspidy requested a review from ocean90 May 16, 2024 15:44
Copy link
Member

@ocean90 ocean90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫶

@swissspidy swissspidy merged commit 8a4a120 into master May 16, 2024
9 of 11 checks passed
@swissspidy swissspidy deleted the cleanup branch May 16, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] CLI CLI commands and tooling [Component] Tests Focus on automated testing [Type] Enhancement New functionality
Projects
None yet
2 participants