Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change type parameter of our sampler #268

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Change type parameter of our sampler #268

merged 1 commit into from
Oct 9, 2023

Conversation

tmke8
Copy link
Member

@tmke8 tmke8 commented Oct 9, 2023

This is for aligning with pytorch

@tmke8
Change type parameter of our sampler
11443ca 
This is for aligning with pytorch
@MylesBartlett
Copy link
Contributor

Very good.

@tmke8 tmke8 enabled auto-merge (squash) October 9, 2023 17:13
@tmke8 tmke8 merged commit 2140e16 into main Oct 9, 2023
5 checks passed
@tmke8 tmke8 deleted the sampler-type-arg branch October 9, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBartlett MylesBartlett MylesBartlett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmke8 @MylesBartlett