Generate CSRs #14
Closed
Generate CSRs #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating a keypair its fairly likely it'll need to be signed by another CA. This creates the CSR required for that process if openssl_generate_csr is true.
|
hi, sure! will be on the road the next couple of days so don't worry if you complete the prs and don't get any from me :) |
|
wanted to say: ... any feedback from me. |
- Needed to create the directory for CSRs to be installed in to - OpenSSL doesn't do it - Added the same subject line as was used for generating the certificate to suppress questions (which obviously can't be answered).
|
I believe this one to be ready, CI permitting :) |
|
THX, merged in release 1.9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Would you be interested in/willing to merge functionality generate CSRs?
The included code works for no-ops but has a bug when trying to generate the CSR. If you are interested in merging it I will put some effort in to fixing the problem :)
(Commit says its from Sept 2014. It isn't.)
thanks,