-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails 7 #256
base: develop
Are you sure you want to change the base?
Rails 7 #256
Conversation
This method is soon to be removed from Rails without deprecation warning, see rails/rails@cb3b37b for more details.
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
=======================================
Coverage 78.56% 78.56%
=======================================
Files 167 166 -1
Lines 3000 3000
=======================================
Hits 2357 2357
Misses 643 643
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I got one error on my tests but I'm not sure if my outpost is setup correctly yet! Failures:
1) Using custom fields as a user manager I can create and use custom fields for services
Failure/Error: click_link custom_field_section.name
Capybara::ElementNotFound:
Unable to find link "Quia ratione dolor fugiat."
# ./spec/features/using_custom_fields_spec.rb:18:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:123:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:122:in `block (2 levels) in <top (required)>'
Finished in 21.33 seconds (files took 2.25 seconds to load)
104 examples, 1 failure
Failed examples:
rspec ./spec/features/using_custom_fields_spec.rb:11 # Using custom fields as a user manager I can create and use custom fields for services |
I've tried tweaking the test in case it's a weird JS/FactoryBot issue, can you try running it again to see if that fixes it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than the issue with the url_for
section all works for me!
<%= image_tag(url_for(FileUpload.find_by(var: 'outpost_logo').file), alt: Setting.outpost_title, class: "site-header__logo") %>
Came across a few bugs in the containerisation work - this was using ruby 3.0.5 not 3.0.3
|
This brings us up to Rails 7! 🎉