Feature/Outpost-92 genericise codebase #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of these import tasks may no longer be needed, or need to be documented. For now this commit moves all of the old files out of the BOD & BFIS folders so that we no longer have hard-coded references to Bucks-specific tasks.
|
Oh yes and the app links still reference Bucks - but we have a separate ticket for that so not tackling that here 😄 |
apricot13
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a lot easier than I thought it would be!
There was only really the import folders left that referenced BOD/BFIS. I've moved everything into the generic
data_importfolder and added descriptions for the tasks so they show up in the task list (when you runrake --tasksorrake -T), but apart from tweaking the imported file names, I have not touched the code. I suggest we don't worry about making sure it all works and is documented until we get to needing to do an import again, because otherwise we might do it all now and then need to change it all again once it comes to actually using it.