Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for reverse sort in sort and ord_sort #2

Merged
merged 5 commits into from
May 29, 2021
Merged

Add option for reverse sort in sort and ord_sort #2

merged 5 commits into from
May 29, 2021

Conversation

jvdp1
Copy link

@jvdp1 jvdp1 commented May 28, 2021

  • Additional option in sort and ord_sort for reverse sorting
  • Add check (error stop) to be sure that it is failing when tests are not succesful

Note: I didn't update the specs, in case this is not correct/appropriate

@jvdp1 jvdp1 mentioned this pull request May 28, 2021
Merged
wclodius2
wclodius2 approved these changes May 29, 2021
View reviewed changes
Copy link
Owner

@wclodius2 wclodius2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you missed any opportunity to reverse operator direction, but since the PR record shows only limited amounts of unchanged code it is hard to be certain. What changes are shown are correct.

@wclodius2 wclodius2 merged commit 5a6f463 into wclodius2:sorting2 May 29, 2021
wclodius2 pushed a commit that referenced this pull request Jun 20, 2021
@gareth-nx
Merge pull request #2 from jvdp1/check_sort
3df88d3 
Mainly added some links
wclodius2 pushed a commit that referenced this pull request Oct 19, 2021
@Jim-215-Fisher
Merge pull request #2 from fortran-lang/master
a16faec 
test
wclodius2 pushed a commit that referenced this pull request Oct 19, 2021
@zoziha
Merge pull request #2 from Aman-Godara/format_string
7ae89fb 
improved aesthetics to make code consistent with stdlib's format
make & cmake passed with msys2-gfortran-10.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wclodius2 wclodius2 wclodius2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvdp1 @wclodius2