Fix for skipped levels being doubled #269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also included are a few changes to avoid recalculating values. Thanks to JohnMatt3000 for working through this with me.
Woops
|
Yeah, I had just noticed that. Thank you. I don't disagree with you, but one of them was being passed already and it was either that or waste time recalculating it. This also prevents there being any discrepancies if we finish a level in between function calls (not likely, but possible I suppose). |
During a long fight the number of levels skipped should be dropping to 0.
|
Errors in build exist in parent branch. This should merge without problem. |
|
No longer necessary after a358f83. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #253
Also included are a few changes to avoid recalculating values. Thanks to JohnMatt3000 for working through this with me.