Unify statistics UI (again) #247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welwood08
force-pushed
the
unify-statistics-ui
branch
6 times, most recently
from
b074455 to
010ae84
Compare
…lane info into the existing lane UI (+5 squashed commit) Squashed commit: [e44a448] Refactor breadcrumbs code [c5f7604] Tidy up [2b2f3f1] ESLint is a cruel mistress. Cruel but fair. [3636c16] Oh ESLint, why do you torment me so? [d77bb42] Fix `m_rgLaneData.forEach is not a function` (Valve uses m_rgLaneData like an array but declares it as an object)
welwood08
force-pushed
the
unify-statistics-ui
branch
from
010ae84 to
dc6729a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix the error in #231.
I think that was because during today's reset Valve changed what was an array into an object (even though they continue to use it like an array). It was working fine for me before the reset with the old code. Works fine for me now (although I've applied this on top of responsiveness2 for my testing).