Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ArchiveTimestampSequence definition #232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arkkors
Copy link

@arkkors arkkors commented Jun 4, 2022

RFC4998, Section 5.1 defines the ArchiveTimestampSequence as:

ArchiveTimeStampChain    ::= SEQUENCE OF ArchiveTimeStamp
ArchiveTimeStampSequence ::= SEQUENCE OF ArchiveTimeStampChain

asn1crypto.tsp defines ArchiveTimeStampSequence as:

class ArchiveTimeStampSequence(SequenceOf):
   _child_spec = ArchiveTimeStamp

and ArchiveTimeStampChain is absent.

This MR fixes the issue.

@arkkors arkkors changed the title Fix evidence record definition Fix ArchiveTimestampSequence definition Jun 4, 2022
@wbond
Copy link
Owner

wbond commented Jun 28, 2022

Thanks for catching this.

Do you have an example file we could add as a fixture to test this with?

@wbond
Copy link
Owner

wbond commented Oct 17, 2022

Pinging you @arkkors to see if you have a test file we could use for this?

@arkkors
Copy link
Author

arkkors commented Oct 17, 2022

Sorry, lost track of that.

I myself don't have test files right now. However there is this repo here: https://github.com/de-bund-bsi-tr-esor/ERVerifyTool
In particular this file looks usable: https://github.com/de-bund-bsi-tr-esor/ERVerifyTool/blob/master/test/1.RFC4998-bin-data_er/BIN_ER.ers

Does that work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants