Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADR0028: deprecation of property
characterizationFactors
; addition of new propertycharacterizationFactorsSources
#46ADR0028: deprecation of property
characterizationFactors
; addition of new propertycharacterizationFactorsSources
#46Changes from 9 commits
86cf047
defa180
7279ba2
cb82b72
2d3157d
fcfef6f
dbea6d7
3ce878a
617dc42
d26418c
1bb74ca
11f438a
04ba350
848fe95
0a1f1d2
18d9516
c1a6762
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raimundo-henriques Why the addition of "of the largest relative share"? Especially given the attribute would be deprecated, why this addition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small typo: "will be removed in version 3.0" (not "on")