Skip to content

Commit

Permalink
Make login screen input feels consistent (opensearch-project#1993) (o…
Browse files Browse the repository at this point in the history
  • Loading branch information
opensearch-trigger-bot[bot] authored Jun 11, 2024
1 parent 1abcc59 commit 92b2c1d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 42 deletions.
3 changes: 1 addition & 2 deletions public/apps/login/login-page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import React, { useState } from 'react';
import {
EuiText,
EuiFieldText,
EuiIcon,
EuiSpacer,
EuiButton,
EuiImage,
Expand Down Expand Up @@ -194,7 +193,7 @@ export function LoginPage(props: LoginPageDeps) {
data-test-subj="user-name"
aria-label="username_input"
placeholder="Username"
prepend={<EuiIcon type="user" />}
icon="user"
onChange={(e) => setUsername(e.target.value)}
value={username}
isInvalid={usernameValidationFailed}
Expand Down
48 changes: 8 additions & 40 deletions public/apps/login/test/__snapshots__/login-page.test.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,10 @@ exports[`Login page renders renders with config value for multiauth 1`] = `
<EuiFieldText
aria-label="username_input"
data-test-subj="user-name"
icon="user"
isInvalid={false}
onChange={[Function]}
placeholder="Username"
prepend={
<EuiIcon
type="user"
/>
}
value=""
/>
</EuiFormRow>
Expand Down Expand Up @@ -195,14 +191,10 @@ exports[`Login page renders renders with config value for multiauth with anonymo
<EuiFieldText
aria-label="username_input"
data-test-subj="user-name"
icon="user"
isInvalid={false}
onChange={[Function]}
placeholder="Username"
prepend={
<EuiIcon
type="user"
/>
}
value=""
/>
</EuiFormRow>
Expand Down Expand Up @@ -364,14 +356,10 @@ exports[`Login page renders renders with config value with anonymous auth enable
<EuiFieldText
aria-label="username_input"
data-test-subj="user-name"
icon="user"
isInvalid={false}
onChange={[Function]}
placeholder="Username"
prepend={
<EuiIcon
type="user"
/>
}
value=""
/>
</EuiFormRow>
Expand Down Expand Up @@ -483,14 +471,10 @@ exports[`Login page renders renders with config value with anonymous auth enable
<EuiFieldText
aria-label="username_input"
data-test-subj="user-name"
icon="user"
isInvalid={false}
onChange={[Function]}
placeholder="Username"
prepend={
<EuiIcon
type="user"
/>
}
value=""
/>
</EuiFormRow>
Expand Down Expand Up @@ -602,14 +586,10 @@ exports[`Login page renders renders with config value: string 1`] = `
<EuiFieldText
aria-label="username_input"
data-test-subj="user-name"
icon="user"
isInvalid={false}
onChange={[Function]}
placeholder="Username"
prepend={
<EuiIcon
type="user"
/>
}
value=""
/>
</EuiFormRow>
Expand Down Expand Up @@ -703,14 +683,10 @@ exports[`Login page renders renders with config value: string array 1`] = `
<EuiFieldText
aria-label="username_input"
data-test-subj="user-name"
icon="user"
isInvalid={false}
onChange={[Function]}
placeholder="Username"
prepend={
<EuiIcon
type="user"
/>
}
value=""
/>
</EuiFormRow>
Expand Down Expand Up @@ -804,14 +780,10 @@ exports[`Login page renders renders with default value: string 1`] = `
<EuiFieldText
aria-label="username_input"
data-test-subj="user-name"
icon="user"
isInvalid={false}
onChange={[Function]}
placeholder="Username"
prepend={
<EuiIcon
type="user"
/>
}
value=""
/>
</EuiFormRow>
Expand Down Expand Up @@ -905,14 +877,10 @@ exports[`Login page renders renders with default value: string array 1`] = `
<EuiFieldText
aria-label="username_input"
data-test-subj="user-name"
icon="user"
isInvalid={false}
onChange={[Function]}
placeholder="Username"
prepend={
<EuiIcon
type="user"
/>
}
value=""
/>
</EuiFormRow>
Expand Down

0 comments on commit 92b2c1d

Please sign in to comment.