-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Test Case upgrade_package_nonvulnerable_to_vulnerable
#5719
Fix Test Case upgrade_package_nonvulnerable_to_vulnerable
#5719
Conversation
UpdateI have reviewed the suggested Grafana packages in a local Wazuh environment. I have used the CVEs that Wazuh has detected. I have added the entries for the new Grafana packages. I have also modified the test to use the new Grafana versions. I need to upload the packages to the bucket and add the URLs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ, some minor changes are requested
deps/wazuh_testing/wazuh_testing/end_to_end/vulnerability_detector_packages/vuln_packages.json
Outdated
Show resolved
Hide resolved
tests/end_to_end/test_vulnerability_detector/cases/test_vulnerability.yaml
Outdated
Show resolved
Hide resolved
tests/end_to_end/test_vulnerability_detector/cases/test_vulnerability.yaml
Outdated
Show resolved
Hide resolved
tests/end_to_end/test_vulnerability_detector/cases/test_vulnerability.yaml
Outdated
Show resolved
Hide resolved
tests/end_to_end/test_vulnerability_detector/cases/test_vulnerability.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Testing along with #5698 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include these changes in the changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT, wait until #5698 to resolve conflicts
Closes #5715
Description
The Grafana package (Not Vulnerable) used so far in the test case
upgrade_package_nonvulnerable_to_vulnerable
is vulnerable toCVE-2022-23498
.To fix this, the following Grafana packages need to be added:
CVE-2023-2801
,CVE-2023-3128
,CVE-2023-1387
,CVE-2023-2183
)The
upgrade_package_nonvulnerable_to_vulnerable
test needs to be fixed with the new packages.Testing performed
Build: https://ci.wazuh.info/job/Test_e2e_system/382
Report: Test_e2e_system_382_test_vulnerability_detector(1).zip
Warning
Some unexpected errors appear, although these are not related to this development. Analysis performed in #5698 (comment)