Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Test Case upgrade_package_nonvulnerable_to_vulnerable #5719

Merged

Conversation

rafabailon
Copy link
Member

@rafabailon rafabailon commented Sep 4, 2024

Closes #5715

Description

The Grafana package (Not Vulnerable) used so far in the test case upgrade_package_nonvulnerable_to_vulnerable is vulnerable to CVE-2022-23498.

To fix this, the following Grafana packages need to be added:

  • Grafana 9.3.16 (Not Vulnerable)
  • Grafana 9.4.1 (CVE-2023-2801, CVE-2023-3128, CVE-2023-1387, CVE-2023-2183)

The upgrade_package_nonvulnerable_to_vulnerable test needs to be fixed with the new packages.


Testing performed

Build: https://ci.wazuh.info/job/Test_e2e_system/382
Report: Test_e2e_system_382_test_vulnerability_detector(1).zip

Warning

Some unexpected errors appear, although these are not related to this development. Analysis performed in #5698 (comment)

@rafabailon rafabailon self-assigned this Sep 4, 2024
@rafabailon
Copy link
Member Author

Update

I have reviewed the suggested Grafana packages in a local Wazuh environment. I have used the CVEs that Wazuh has detected.

I have added the entries for the new Grafana packages. I have also modified the test to use the new Grafana versions.

I need to upload the packages to the bucket and add the URLs.

@rafabailon rafabailon marked this pull request as ready for review September 16, 2024 10:35
Copy link
Member

@Rebits Rebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ, some minor changes are requested

Copy link
Member

@Rebits Rebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rebits
Copy link
Member

Rebits commented Sep 16, 2024

Testing along with #5698
Build: https://ci.wazuh.info/job/Test_e2e_system/381/

Copy link
Member

@Rebits Rebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include these changes in the changelog

Rebits
Rebits previously approved these changes Sep 18, 2024
Copy link
Member

@Rebits Rebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, wait until #5698 to resolve conflicts

@juliamagan juliamagan merged commit 6a4e8ec into 4.9.1 Sep 18, 2024
@juliamagan juliamagan deleted the fix/5715-fix-upgrade-case-from-nonvulnerable-to-vulnerable branch September 18, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grafana package used for upgrade_package_nonvulnerable_to_vulnerable case is vulnerable
3 participants