Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force instance name to be defined in vagrant deploy #5342

Conversation

c-bordon
Copy link
Member

@c-bordon c-bordon commented May 6, 2024

Close #5311

The PR aims to validate the configuration of an instance name in vagrant, either with the --instance-name or --label-issue parameter

Tests:

Vagrant local: #5311 (comment)
Issue format validation: #5311 (comment)
AWS: #5311 (comment)
Vagrant macOS ARM: #5311 (comment)
Instance dir concurrency: #5311 (comment)

@c-bordon c-bordon marked this pull request as ready for review May 6, 2024 18:39
@c-bordon c-bordon requested review from rauldpm and teddytpc1 May 6, 2024 18:41
@c-bordon c-bordon self-assigned this May 6, 2024
@c-bordon c-bordon linked an issue May 6, 2024 that may be closed by this pull request
4 tasks
@c-bordon c-bordon requested a review from mhamra May 7, 2024 12:16
@pro-akim pro-akim self-requested a review May 7, 2024 15:01
Copy link
Member

@pro-akim pro-akim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pro-akim pro-akim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Notes

LGTM

@teddytpc1 teddytpc1 merged commit 7eb886b into 4495-dtt1-release May 7, 2024
@teddytpc1 teddytpc1 deleted the enhancement/5311-dtt1-identify-allocator-module-resources-uniquely branch May 7, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DTT1 - Identify Allocator module resources uniquely
3 participants