Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Central component tests #5289

Closed
wants to merge 10 commits into from
Closed

Adding Central component tests #5289

wants to merge 10 commits into from

Conversation

pro-akim
Copy link
Member

@pro-akim pro-akim commented Apr 24, 2024 •
edited
Loading

Adding Central component tests

Adding tests for central components installed through the AIO method.

The following list of tests is included:

  • Test install
  • Test stop
  • Test restart
  • Test uninstall

@pro-akim pro-akim self-assigned this Apr 24, 2024
@pro-akim pro-akim linked an issue Apr 24, 2024 that may be closed by this pull request
DTT1 - Test Module - Central component tests #5219
Closed
5 tasks
@mhamra mhamra self-requested a review April 26, 2024 12:52
mhamra
mhamra suggested changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@mhamra mhamra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pro-akim, could you change the name of the example file?

...les/workflow_engine/examples/central_components/aws/dtt1-central_components-poc-vagrant.yaml Outdated Show resolved Hide resolved
@mhamra
Copy link
Contributor

mhamra commented Apr 26, 2024 •
edited
Loading

TEST RESULT

AWS test

I've run the example deployability/modules/workflow_engine/examples/central_components/aws/dtt1-central_components-poc-vagrant.yaml provided by this PR, and I've obtained this result:

workflow.log

No failures are found on it.

Vagrant tests

I've run the example deployability/modules/workflow_engine/examples/central_components/vagrant/dtt1-central_components-poc-vagrant.yaml provided by this PR, and I've obtained this result:

workflow.log

  • The tests on linux-ubuntu-22.04 run fine.
  • The Oracle-linux test task finished with errors.

@pro-akim pro-akim requested a review from mhamra April 29, 2024 10:58
mhamra
mhamra approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@mhamra mhamra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pro-akim
I've run the workflow for AWS and Vagrant (the details are in this comment)

While the AWS central component tests passed ok without failures, the Vagrant central component tests didn't run for all the OSs. They finished without failures only for one OS, but the problem doesn't seem related to this PR.

rauldpm
rauldpm requested changes Apr 29, 2024
View reviewed changes
Copy link
Member

@rauldpm rauldpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magnificent work!

Just notes regarding the reference to components, PEP8, or checking system commands

deployability/modules/testing/tests/helpers/central.py Outdated Show resolved Hide resolved
deployability/modules/testing/tests/helpers/central.py Outdated Show resolved Hide resolved
deployability/modules/testing/tests/helpers/central.py Outdated Show resolved Hide resolved
deployability/modules/testing/tests/helpers/dashboard.py Outdated Show resolved Hide resolved
deployability/modules/testing/tests/helpers/central.py Outdated Show resolved Hide resolved
deployability/modules/testing/tests/test_central_components/test_stop.py Outdated Show resolved Hide resolved
deployability/modules/testing/tests/test_central_components/test_uninstall.py Outdated Show resolved Hide resolved
deployability/modules/testing/tests/test_manager/test_stop.py Show resolved Hide resolved
...modules/workflow_engine/examples/central_components/aws/dtt1-central_components-poc-aws.yaml Outdated Show resolved Hide resolved
...workflow_engine/examples/central_components/vagrant/dtt1-central_components-poc-vagrant.yaml Outdated Show resolved Hide resolved
@pro-akim pro-akim requested a review from rauldpm May 2, 2024 11:01
@pro-akim pro-akim closed this May 6, 2024
@pro-akim pro-akim reopened this May 6, 2024
@pro-akim
Copy link
Member Author

pro-akim commented May 6, 2024

Update

This issue is closed.

All the changes were integrated in #5324

@pro-akim pro-akim closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhamra mhamra mhamra approved these changes

@rauldpm rauldpm Awaiting requested review from rauldpm

Assignees

@pro-akim pro-akim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DTT1 - Test Module - Central component tests
3 participants
@pro-akim @mhamra @rauldpm