-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding general documentation to deployability tests #4976
Merged
QU3B1M
merged 17 commits into
enhancement/4871-dtt1-iteration-3-general-improvements
from
enhancement/4889-dtt1-iteration-3-general-improvements-documentation
Feb 19, 2024
Merged
Adding general documentation to deployability tests #4976
QU3B1M
merged 17 commits into
enhancement/4871-dtt1-iteration-3-general-improvements
from
enhancement/4889-dtt1-iteration-3-general-improvements-documentation
Feb 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-general-improvements Implement changes from generic module
…-allocation-module-improve-sizes-and-os-for-aws-provider-to Updated AWS amis
…-allocation-module-improve-sizes-and-os-for-vagrant-provider Added support for multiple OSes for vagrant
…o enhancement/4865-dtt1-iteration-3-allocation-module-enable-loading-an-existing-ssh-key-pair
…-allocation-module-implement-name-and-type-labels-on-vms-creation Added support for labels for AWS EC2 creation
…-allocation-module-enable-loading-an-existing-ssh-key-pair Added support for custom ssh key pairs
2 tasks
Removing /
fcaffieri
approved these changes
Feb 19, 2024
QU3B1M
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
QU3B1M
merged commit Feb 19, 2024
a4dc25c
into
enhancement/4871-dtt1-iteration-3-general-improvements
QU3B1M
deleted the
enhancement/4889-dtt1-iteration-3-general-improvements-documentation
branch
February 19, 2024 20:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding general documentation to deployability tests