-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provision module Improvements and support actions #4883
Provision module Improvements and support actions #4883
Conversation
…changes to the module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Notes
LGTM
status = install.install_component() | ||
|
||
return status | ||
def validateManagerIp(self, components, ip): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no documentation for the function
|
||
@classmethod | ||
def validate_action(cls, values): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no documentation for the function
|
||
@classmethod | ||
def validate_inventory(cls, values): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no documentation for the function
|
||
@validator('install', pre=True) | ||
def validate_install(cls, install) -> Union[None, List[str]]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no documentation for the function
|
||
@validator('uninstall', pre=True) | ||
def validate_uninstall(cls, uninstall) -> Union[None, List[str]]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no documentation for the function
|
||
@classmethod | ||
def validate_install_uninstall(cls, components) -> Union[None, List[str]]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no documentation for the function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9a82f46
into
4852-dtt1-iteration-3-provision-module-improvements-and-fixes
Description
The following improvements were made:
Test
Full log