Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CVEs alerts inventory for Vulnerability Detector: alert on vulnerability removal #1436

Merged
merged 2 commits into from
Jun 11, 2021
Merged

CVEs alerts inventory for Vulnerability Detector: alert on vulnerability removal #1436

merged 2 commits into from
Jun 11, 2021

Conversation

mdengra
Copy link
Contributor

@mdengra mdengra commented Jun 10, 2021

Related issue
Closes #1431

Description

This PR adds a test to verify if when a vulnerability is removed from the inventory, a new alert is triggered as part of #1261. This is a new alert type generated when a vulnerability no longer affects an agent because of a package upgrade/removal.

Test results

Manager

Tested on CentOS 8 (local)

manager

Tested on CentOS 7 (Jenkins)

jenkins_centos7

Documentation

docu

Tests

  • Proven that tests pass when they have to pass.
  • Proven that tests fail when they have to fail.
  • Python codebase satisfies PEP-8 style style guide. pycodestyle --max-line-length=120 --show-source --show-pep8 file.py.
  • Python codebase is documented following the Google Style for Python docstrings.
  • The test is documented in wazuh-qa/docs.
  • provision_documentation.sh generate the docs without errors.

@mdengra mdengra requested review from BraulioV and spothound June 10, 2021 07:51
@mdengra mdengra self-assigned this Jun 10, 2021
mdengra added 2 commits June 11, 2021 12:07
@mdengra
Add test_alert_vulnerability_removal to vulnerability detector tests
1644b48 
Update functions in vulnerability_detector module:
  * update_package
  * delete_package
to use wazuh-db socket #1431
@mdengra
Move test_alert_vulnerability_removal to test_scan_results category
f81247e 
Fix links in test_scan_results documentation index
Resolve conflicts #1431
@mdengra mdengra force-pushed the 1431-cve-alerts-inventory-alert_vulnerability_removal branch from 693c2cd to f81247e Compare June 11, 2021 10:30
@BraulioV BraulioV merged commit a69424b into 1261-cve-alerts-inventory Jun 11, 2021
@BraulioV BraulioV deleted the 1431-cve-alerts-inventory-alert_vulnerability_removal branch June 11, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BraulioV BraulioV BraulioV approved these changes

@spothound spothound Awaiting requested review from spothound

Assignees

@mdengra mdengra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdengra @BraulioV