Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DTT1 - Iteration 3 - Test module - Adding granularity to test validations #5215

Closed
pro-akim opened this issue Apr 15, 2024 · 7 comments · Fixed by #5268
Closed

DTT1 - Iteration 3 - Test module - Adding granularity to test validations #5215

pro-akim opened this issue Apr 15, 2024 · 7 comments · Fixed by #5268
Assignees
@pro-akim
Labels
level/task Task issue type/enhancement

Comments

@pro-akim
Copy link
Member

pro-akim commented Apr 15, 2024 •
edited
Loading

Adding granularity to test validations

Change in Agent tests

  1. Test install
  2. Test registration
  3. Test stop
  4. Test restart
  5. Test uninstall

to

  1. Test install
  2. Test registration (Enroll using ossec.conf targeting a specific manager)
  3. Test connection (Establish a connection with a single manager via TCP)
  4. Test basic_info (OS, arch, version)
  5. Test stop
  6. Test restart
  7. Test uninstall Confirm no remnants post-uninstallation (e.g., processes, services, ports)
@pro-akim pro-akim self-assigned this Apr 15, 2024
@wazuhci wazuhci moved this to In progress in Release 4.9.0 Apr 15, 2024
pro-akim added a commit that referenced this issue Apr 16, 2024
@pro-akim
fix(#5215): Adding port, process check, basic_info and connection
427f465
pro-akim added a commit that referenced this issue Apr 16, 2024
@pro-akim
fix(#5215): white space fix
5b52050
@pro-akim
Copy link
Member Author

pro-akim commented Apr 16, 2024 •
edited
Loading

Update

Tested all the new tests.

Testing in AWS 🔴 => 🟢

- linux-oracle-9-amd64
- linux-centos-7-amd64
- linux-centos-8-amd64
- linux-redhat-7-amd64
- linux-redhat-8-amd64
- linux-redhat-9-amd64
- linux-amazon-2-amd64
- linux-ubuntu-18.04-amd64
- linux-ubuntu-20.04-amd64
- linux-ubuntu-22.04-amd64
- linux-debian-10-amd64
- linux-debian-11-amd64
- linux-debian-12-amd64
- linux-opensuse-15-amd64
- linux-suse-15-amd64
- linux-amazon-2023-amd64

In suse15, some adjustments are required in test_basic_info 🔴 => 🟢

[2024-04-16 21:58:00,809] [ERROR] [Testing]: There is a mismatch between the OS name and the OS name of the installed agent

Testing in Vagrant 🟢

- linux-oracle-9-amd64
- linux-centos-7-amd64
- linux-centos-8-amd64
- linux-redhat-7-amd64
- linux-redhat-8-amd64
- linux-redhat-9-amd64
- linux-amazon-2-amd64
- linux-ubuntu-18.04-amd64
- linux-ubuntu-20.04-amd64
- linux-ubuntu-22.04-amd64
- linux-debian-10-amd64
- linux-debian-11-amd64
- linux-debian-12-amd64
- linux-opensuse-15-amd64

@pro-akim pro-akim linked a pull request Apr 16, 2024 that will close this issue
Adding basic_info and connection validations #5225
Closed
2 tasks
pro-akim added a commit that referenced this issue Apr 16, 2024
@pro-akim
fix(#5215): Adding fixes in basic_info log and changing lsof to ss
a6e5046
pro-akim added a commit that referenced this issue Apr 17, 2024
@pro-akim
fix(#5215): Fixing SUSE 15
5603e91
@wazuhci wazuhci moved this from In progress to Pending review in Release 4.9.0 Apr 17, 2024
@rauldpm
Copy link
Member

rauldpm commented Apr 18, 2024

ETA moved 1 day due to pending review

@wazuhci wazuhci moved this from Pending review to In review in Release 4.9.0 Apr 18, 2024
@pro-akim pro-akim mentioned this issue Apr 18, 2024
Closed
2 tasks
@wazuhci wazuhci moved this from In review to On hold in Release 4.9.0 Apr 18, 2024
pro-akim added a commit that referenced this issue Apr 18, 2024
@pro-akim
fix(#5215): changes after review
3220fb7
@pro-akim
Copy link
Member Author

Update

New changes in 4495-dtt1-release were merged

@wazuhci wazuhci moved this from On hold to Pending review in Release 4.9.0 Apr 18, 2024
pro-akim added a commit that referenced this issue Apr 18, 2024
@pro-akim
fix(#5215): Adding granularity
5045ba3
@pro-akim pro-akim removed a link to a pull request Apr 18, 2024
Adding basic_info and connection validations #5225
Closed
2 tasks
@pro-akim pro-akim linked a pull request Apr 18, 2024 that will close this issue
Adding basic_info and connection validations #5268
Merged
2 tasks
pro-akim added a commit that referenced this issue Apr 18, 2024
@pro-akim
fix(#5215): Adding missing part
852bbe5
pro-akim added a commit that referenced this issue Apr 18, 2024
@pro-akim
fix(#5215): Removing duplicated part
a0e82bb
pro-akim added a commit that referenced this issue Apr 18, 2024
@pro-akim
fix(#5215): indentation fixes
ba5e410
pro-akim added a commit that referenced this issue Apr 18, 2024
@pro-akim
fix(#5215): space fixes
cd9f2e3
pro-akim added a commit that referenced this issue Apr 18, 2024
@pro-akim
fix(#5215): space fixes2
5d21f05
pro-akim added a commit that referenced this issue Apr 18, 2024
@pro-akim
fix(#5215): space fixes3
db0825d
pro-akim added a commit that referenced this issue Apr 18, 2024
@pro-akim
fix(#5215): Fixing test log imports
b28f2ad
@fcaffieri
Copy link
Member

Needs to review and generate a new PR due to conflicts unresolved with changes in 4495-dtt1-release

@wazuhci wazuhci moved this from Pending review to On hold in Release 4.9.0 Apr 18, 2024
@pro-akim
Copy link
Member Author

Update

Conflicts fixed.
Moved to pending review

@wazuhci wazuhci moved this from On hold to In progress in Release 4.9.0 Apr 19, 2024
@wazuhci wazuhci moved this from In progress to Pending review in Release 4.9.0 Apr 19, 2024
@fcaffieri
Copy link
Member

LGTM

@wazuhci wazuhci moved this from Pending review to Pending final review in Release 4.9.0 Apr 19, 2024
@wazuhci wazuhci moved this from Pending final review to In final review in Release 4.9.0 Apr 19, 2024
@rauldpm
Copy link
Member

rauldpm commented Apr 19, 2024

LGTM

@rauldpm rauldpm closed this as completed Apr 19, 2024
@wazuhci wazuhci moved this from In final review to Done in Release 4.9.0 Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pro-akim pro-akim

Labels
level/task Task issue type/enhancement
Projects
No open projects
Release 4.9.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding basic_info and connection validations wazuh/wazuh-qa
3 participants
@rauldpm @fcaffieri @pro-akim