Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added package_release name modification #2618

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

mjcr99
Copy link
Member

@mjcr99 mjcr99 commented Nov 21, 2023

Related issue
#2333

Description

This PR tests and solves the test fail problem when the development branch contains /.

Logs example

image

Tests

To test this PR is mandatory to add a dummy commit that triggers the failing test in GH Actions, this dummy commit can simply add a whitespace in the rpms/SPECS/wazuh-manager.spec for test it in RPM and debs/SPECS/wazuh-manager/debian/postinst for DEB packages.

@mjcr99 mjcr99 force-pushed the fix/2333-branch-name-causes-test-fail branch 3 times, most recently from f8274ca to fa0dfa7 Compare November 22, 2023 09:11
@jotacarma90 jotacarma90 linked an issue Nov 22, 2023 that may be closed by this pull request
@mjcr99 mjcr99 force-pushed the fix/2333-branch-name-causes-test-fail branch 3 times, most recently from 458931c to 0809738 Compare November 22, 2023 12:29
Copy link
Member

@jotacarma90 jotacarma90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vikman90 vikman90 merged commit eed7115 into 4.7.1 Nov 23, 2023
@vikman90 vikman90 deleted the fix/2333-branch-name-causes-test-fail branch November 23, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GH action tests fail if branch name contains a slash /
3 participants