Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid cast from SecureIndexClient to NodeClient #8

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

AlexRuiz7
Copy link
Member

Description

This PR fixes the invalid cast from SecureIndexClient to NodeClient.

Issues Resolved

Closes #7

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AlexRuiz7 AlexRuiz7 self-assigned this Oct 2, 2024
@AlexRuiz7 AlexRuiz7 requested a review from a team as a code owner October 2, 2024 10:41
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Definition
image

Email
image

@AlexRuiz7 AlexRuiz7 merged commit 0a9b2bf into master Oct 2, 2024
1 check passed
@AlexRuiz7 AlexRuiz7 deleted the ci/7-fix-client-cast-bug branch October 2, 2024 12:47
AlexRuiz7 added a commit that referenced this pull request Nov 7, 2024
* Fix invalid cast from SecureIndexClient to NodeClient

* Add labels to issue templates
AlexRuiz7 added a commit that referenced this pull request Nov 15, 2024
* Fix invalid cast from SecureIndexClient to NodeClient

* Add labels to issue templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] SecureIndexClient cannot be cast to NodeClient
2 participants