Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds workflow retry if it fails #411

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Adds workflow retry if it fails #411

merged 2 commits into from
Nov 19, 2024

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Nov 12, 2024 •
edited
Loading

Description

Retries are added if package creation action fails

Issues Resolved

Test

Run the package creation script, it should create the packages correctly.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Nov 12, 2024
@yenienserrano yenienserrano linked an issue Nov 12, 2024 that may be closed by this pull request
Authorization error when building the RPM package #354
Closed
@yenienserrano yenienserrano mentioned this pull request Nov 12, 2024
Closed
7 tasks
Desvelao
Desvelao reviewed Nov 18, 2024
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The approach to retry the action to build the package could help to mitigate the problem. I think we should research if the problem is frequent.

guidomodarelli
guidomodarelli approved these changes Nov 19, 2024
View reviewed changes
Copy link

@guidomodarelli guidomodarelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend:
⚫: The test hasn't started yet.
🟢: All checks passed.
🟡: There is at least one expected fail or skipped test and no failures.
🔴: There is at least one failed check.
⚪: Doesn't apply.

CR 🟢

@asteriscos asteriscos merged commit 86717d0 into master Nov 19, 2024
84 of 88 checks passed
@asteriscos asteriscos deleted the enhancement/354-authorization-error-when-building-the-rpm-package-2.17.1 branch November 19, 2024 13:56
Desvelao pushed a commit that referenced this pull request Nov 19, 2024
@yenienserrano @Desvelao
Adds workflow retry if it fails (#411)
d9bc336
@Desvelao Desvelao mentioned this pull request Nov 19, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao left review comments

@guidomodarelli guidomodarelli guidomodarelli approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Authorization error when building the RPM package
4 participants
@yenienserrano @Desvelao @guidomodarelli @asteriscos