Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change order of menu sections #372

Merged
merged 5 commits into from
Oct 25, 2024
Merged

Change order of menu sections #372

merged 5 commits into from
Oct 25, 2024

Conversation

chantal-kelm
Copy link
Member

@chantal-kelm chantal-kelm commented Oct 18, 2024 •
edited
Loading

Description

Show the dashboard management section first and then the indexer management section.

Issues Resolved

Evidence

Captura de pantalla 2024-10-18 a la(s) 5 32 07 p  m

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@chantal-kelm chantal-kelm self-assigned this Oct 18, 2024
@chantal-kelm chantal-kelm linked an issue Oct 18, 2024 that may be closed by this pull request
Create agents management menu wazuh/wazuh-dashboard-plugins#7069
Closed
3 tasks
@Desvelao
Copy link
Member

The category order of Indexer management should be changed here too: https://github.com/wazuh/wazuh-dashboard/blob/7069-change-order-of-menu-sections/dev-tools/build-packages/base/generate_base.sh#L170

yenienserrano
yenienserrano approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@chantal-kelm
Copy link
Member Author

The category order of Indexer management should be changed here too: https://github.com/wazuh/wazuh-dashboard/blob/7069-change-order-of-menu-sections/dev-tools/build-packages/base/generate_base.sh#L170

Fixed in commit d424cae

asteriscos
asteriscos approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

image

@Desvelao Desvelao merged commit 1c3e1e2 into 4.10.0 Oct 25, 2024
60 checks passed
@Desvelao Desvelao deleted the 7069-change-order-of-menu-sections branch October 25, 2024 07:00
Tostti pushed a commit that referenced this pull request Nov 5, 2024
@chantal-kelm @asteriscos @Tostti
Change order of menu sections (#372)
47ae6cc 
Co-authored-by: Federico Rodriguez <[email protected]>
@asteriscos asteriscos mentioned this pull request Nov 11, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@asteriscos asteriscos asteriscos approved these changes

Assignees

@chantal-kelm chantal-kelm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create agents management menu
4 participants
@chantal-kelm @Desvelao @asteriscos @yenienserrano