Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setting new home #282

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Aug 28, 2024

Description

The setting to configure the new home page is deleted because it is not finished and has some errors to use it at the moment.

Issues Resolved

Test

  1. Navigate to Dashboard management > Advanced settings
  2. The setting home:useNewHomePage should not appear.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Aug 28, 2024
@Machi3mfl Machi3mfl self-requested a review September 2, 2024 12:33
@chantal-kelm chantal-kelm self-requested a review September 2, 2024 18:11
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TEST 🟢
image

CR 🟢

LGTM

Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Screenshot 2024-09-03 at 09 33 13

@guidomodarelli
Copy link

guidomodarelli commented Sep 3, 2024

CR 🟢
TEST 🟢
image

@Tostti Tostti merged commit 6d3367c into 4.10.0 Sep 3, 2024
60 checks passed
@Tostti Tostti deleted the maintenance/280-compatibility-opensearch-216-remove-the-new-menu-advanced-setting branch September 3, 2024 14:07
yenienserrano added a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Compatibility OpenSearch 2.16] Remove the new menu advanced setting
4 participants