Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections to indexer management and dashboard management in the left menu #245

Conversation

chantal-kelm
Copy link
Member

@chantal-kelm chantal-kelm commented Jul 16, 2024

Description

This PR resolves:

  • Fix wrong order of Indexer management and Dashboard management app category on the left-side menu.
  • Fix wrong app category name Index management to Indexer management on the left-side menu.

Evidence

image

Issues Resolved

6823

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano
Copy link
Member

Test: 🟢

image

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.70%. Comparing base (5a302c9) to head (5d09fa8).
Report is 16 commits behind head on 4.9.0.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##            4.9.0     #245       +/-   ##
===========================================
+ Coverage   31.31%   44.70%   +13.38%     
===========================================
  Files        2211     1633      -578     
  Lines       44413    32930    -11483     
  Branches     6871     6219      -652     
===========================================
+ Hits        13909    14720      +811     
+ Misses      29884    17077    -12807     
- Partials      620     1133      +513     
Flag Coverage Δ
Linux_1 ?
Linux_3 44.70% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Desvelao
Copy link
Member

🟢 Test

image

@Desvelao Desvelao merged commit 2f99bde into 4.9.0 Jul 22, 2024
60 checks passed
@Desvelao Desvelao deleted the bug/6823-corrections-to-indexer-management-and-dashboard-management-in-the-left-menu branch July 22, 2024 13:35
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Corrections to indexer management and dashboard management in the left menu
4 participants