Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the original home icon size #243

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

yenienserrano
Copy link
Member

Description

Return the home icon to the size it had in previous versions.

Issues Resolved

Changelog

It checks if the expanded headers are enabled or not as opensearch does.

https://github.com/opensearch-project/OpenSearch-Dashboards/blob/2.13.0/src/core/public/chrome/ui/header/home_icon.tsx#L30

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Jul 15, 2024
@yenienserrano yenienserrano linked an issue Jul 15, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 35.30%. Comparing base (5a302c9) to head (a75075b).
Report is 13 commits behind head on 4.9.0.

Files Patch % Lines
src/core/public/chrome/ui/header/home_icon.tsx 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            4.9.0     #243      +/-   ##
==========================================
+ Coverage   31.31%   35.30%   +3.98%     
==========================================
  Files        2211     1896     -315     
  Lines       44413    36525    -7888     
  Branches     6871     6635     -236     
==========================================
- Hits        13909    12894    -1015     
+ Misses      29884    22782    -7102     
- Partials      620      849     +229     
Flag Coverage Δ
Linux_1 ?
Linux_4 35.30% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chantal-kelm chantal-kelm self-requested a review July 16, 2024 15:20
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

image

@Desvelao
Copy link
Member

🟢 Test

image

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Desvelao Desvelao merged commit 3574090 into 4.9.0 Jul 22, 2024
60 checks passed
@Desvelao Desvelao deleted the bug/242-the-logo-is-smaller-than-in-previous-versions branch July 22, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The logo is smaller than in previous versions
4 participants