-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore the original home icon size #243
Restore the original home icon size #243
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## 4.9.0 #243 +/- ##
==========================================
+ Coverage 31.31% 35.30% +3.98%
==========================================
Files 2211 1896 -315
Lines 44413 36525 -7888
Branches 6871 6635 -236
==========================================
- Hits 13909 12894 -1015
+ Misses 29884 22782 -7102
- Partials 620 849 +229
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Return the home icon to the size it had in previous versions.
Issues Resolved
Changelog
It checks if the expanded headers are enabled or not as opensearch does.
https://github.com/opensearch-project/OpenSearch-Dashboards/blob/2.13.0/src/core/public/chrome/ui/header/home_icon.tsx#L30
Check List
yarn test:jest
yarn test:jest_integration