Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error generating packages in branches that contain / #183

Merged
merged 9 commits into from
May 23, 2024
Merged

Fix error generating packages in branches that contain / #183

merged 9 commits into from
May 23, 2024

Conversation

Tostti
Copy link
Member

@Tostti Tostti commented May 20, 2024 •
edited
Loading

Description

This PR fixes the package generation procedure, which failed when the branch contained a /

Issues Resolved

#180

Evidence

Workflow successfully completed using a branch named bug/package-generation-branch-with-slash

https://github.com/wazuh/wazuh-dashboard/actions/runs/9161475445

For that test, I had to replace a reference that otherwise would point to 4.9.0. After testing, I set the reference back to its original name.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Tostti Tostti self-assigned this May 20, 2024
@Tostti Tostti marked this pull request as ready for review May 20, 2024 18:09
@Tostti Tostti linked an issue May 20, 2024 that may be closed by this pull request
Wazuh dashboard workflow run fails when managing the base file #180
Closed
@lucianogorza lucianogorza self-requested a review May 20, 2024 20:54
@lucianogorza
Copy link

lucianogorza commented May 20, 2024 •
edited
Loading

CR 🟢

Test 🟢

lucianogorza
lucianogorza previously approved these changes May 23, 2024
View reviewed changes
Copy link

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tostti Tostti merged commit 71b3eda into 4.9.0 May 23, 2024
60 checks passed
@Tostti Tostti deleted the bug/package-generation-branch-with-slash branch May 23, 2024 18:28
yenienserrano pushed a commit that referenced this pull request Jun 18, 2024
@Tostti @yenienserrano
Fix error generating packages in branches that contain / (#183)
88ea930
yenienserrano pushed a commit that referenced this pull request Jul 12, 2024
@Tostti @yenienserrano
Fix error generating packages in branches that contain / (#183)
ff29f3d
yenienserrano pushed a commit that referenced this pull request Aug 19, 2024
@Tostti @yenienserrano
Fix error generating packages in branches that contain / (#183)
05dc30b
yenienserrano pushed a commit that referenced this pull request Oct 28, 2024
@Tostti @yenienserrano
Fix error generating packages in branches that contain / (#183)
5904e49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucianogorza lucianogorza lucianogorza approved these changes

Assignees

@Tostti Tostti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wazuh dashboard workflow run fails when managing the base file
2 participants
@Tostti @lucianogorza