Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with OpenSearch 2.11.1 #131

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Compatibility with OpenSearch 2.11.1 #131

merged 3 commits into from
Dec 22, 2023

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Dec 19, 2023 •
edited
Loading

Description

Compatibility with OpenSearch 2.11.1

Issues Resolved

Evidence

image

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

AlexRuiz7 and others added 3 commits December 19, 2023 16:12
@AlexRuiz7 @yenienserrano
@Machi3mfl @Tostti @Desvelao
Add compatibility with OpenSearch 2.11.0 (#121)
cb1c680 
Signed-off-by: yenienserrano <[email protected]>
Signed-off-by: Álex Ruiz <[email protected]>
Signed-off-by: Ian Yenien Serrano <[email protected]>
Co-authored-by: Ian Yenien Serrano <[email protected]>
Co-authored-by: Maximiliano Ibarra <[email protected]>
Co-authored-by: Nicolas Agustin Guevara Pihen <[email protected]>
Co-authored-by: Antonio <[email protected]>
Co-authored-by: yenienserrano <[email protected]>
@yenienserrano
Updating our package construction methods (#122)
853a0ed
@yenienserrano
Change build action (#124)
4b0ca37 
Signed-off-by: Ian Yenien Serrano <[email protected]>
@yenienserrano yenienserrano linked an issue Dec 19, 2023 that may be closed by this pull request
Compatibility with OpenSearch 2.11.1 #129
Closed
4 tasks
@yenienserrano yenienserrano self-assigned this Dec 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2023 •
edited
Loading

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (989d8f4) 66.84% compared to head (4b0ca37) 55.64%.

Files Patch % Lines
...lic/injected_metadata/injected_metadata_service.ts 0.00% 3 Missing ⚠️
src/core/public/chrome/ui/header/home_icon.tsx 0.00% 2 Missing ⚠️
src/core/public/rendering/rendering_service.tsx 0.00% 2 Missing ⚠️
src/cli_plugin/install/settings.js 75.00% 1 Missing ⚠️
src/core/server/http/http_service.ts 0.00% 1 Missing ⚠️
src/plugins/home/public/plugin.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff             @@
##           2.11.1     #131       +/-   ##
===========================================
- Coverage   66.84%   55.64%   -11.20%     
===========================================
  Files        3284     2995      -289     
  Lines       63167    59206     -3961     
  Branches    10048     9438      -610     
===========================================
- Hits        42222    32945     -9277     
- Misses      18469    24303     +5834     
+ Partials     2476     1958      -518
Flag Coverage Δ
Linux_1 35.25% <55.55%> (+<0.01%) ⬆️
Linux_2 ?
Linux_3 43.83% <52.63%> (-0.01%) ⬇️
Linux_4 35.47% <61.53%> (-0.02%) ⬇️
Windows_1 ?
Windows_2 ?
Windows_3 ?
Windows_4 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yenienserrano
Copy link
Member Author

The test that is failing has been skipped in the 2.11 branch because it is failing

https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/2.11/cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/discover.spec.js#L152

@yenienserrano yenienserrano marked this pull request as ready for review December 20, 2023 08:55
Tostti
Tostti approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tostti Tostti merged commit bd4fe7a into 2.11.1 Dec 22, 2023
107 of 108 checks passed
@Tostti Tostti deleted the wz-2.11.1 branch December 22, 2023 15:30
yenienserrano added a commit that referenced this pull request Feb 21, 2024
@yenienserrano @AlexRuiz7
@Machi3mfl @Tostti @Desvelao
Compatibility with OpenSearch 2.11.1 (#131)
d481dca 
Signed-off-by: yenienserrano <[email protected]>
Signed-off-by: Álex Ruiz <[email protected]>
Signed-off-by: Ian Yenien Serrano <[email protected]>
Co-authored-by: Álex Ruiz <[email protected]>
Co-authored-by: Maximiliano Ibarra <[email protected]>
Co-authored-by: Nicolas Agustin Guevara Pihen <[email protected]>
Co-authored-by: Antonio <[email protected]>
Tostti added a commit that referenced this pull request Apr 5, 2024
@yenienserrano @AlexRuiz7
@Machi3mfl @Tostti @Desvelao
Compatibility with OpenSearch 2.11.1 (#131)
ee03353 
Signed-off-by: yenienserrano <[email protected]>
Signed-off-by: Álex Ruiz <[email protected]>
Signed-off-by: Ian Yenien Serrano <[email protected]>
Co-authored-by: Álex Ruiz <[email protected]>
Co-authored-by: Maximiliano Ibarra <[email protected]>
Co-authored-by: Nicolas Agustin Guevara Pihen <[email protected]>
Co-authored-by: Antonio <[email protected]>
yenienserrano added a commit that referenced this pull request Jun 18, 2024
@yenienserrano @AlexRuiz7
@Machi3mfl @Tostti @Desvelao
Compatibility with OpenSearch 2.11.1 (#131)
33dd6ab 
Signed-off-by: yenienserrano <[email protected]>
Signed-off-by: Álex Ruiz <[email protected]>
Signed-off-by: Ian Yenien Serrano <[email protected]>
Co-authored-by: Álex Ruiz <[email protected]>
Co-authored-by: Maximiliano Ibarra <[email protected]>
Co-authored-by: Nicolas Agustin Guevara Pihen <[email protected]>
Co-authored-by: Antonio <[email protected]>
yenienserrano added a commit that referenced this pull request Jul 12, 2024
@yenienserrano @AlexRuiz7
@Machi3mfl @Tostti @Desvelao
Compatibility with OpenSearch 2.11.1 (#131)
a4c086a 
Signed-off-by: yenienserrano <[email protected]>
Signed-off-by: Álex Ruiz <[email protected]>
Signed-off-by: Ian Yenien Serrano <[email protected]>
Co-authored-by: Álex Ruiz <[email protected]>
Co-authored-by: Maximiliano Ibarra <[email protected]>
Co-authored-by: Nicolas Agustin Guevara Pihen <[email protected]>
Co-authored-by: Antonio <[email protected]>
yenienserrano added a commit that referenced this pull request Aug 19, 2024
@yenienserrano @AlexRuiz7
@Machi3mfl @Tostti @Desvelao
Compatibility with OpenSearch 2.11.1 (#131)
6926478 
Signed-off-by: yenienserrano <[email protected]>
Signed-off-by: Álex Ruiz <[email protected]>
Signed-off-by: Ian Yenien Serrano <[email protected]>
Co-authored-by: Álex Ruiz <[email protected]>
Co-authored-by: Maximiliano Ibarra <[email protected]>
Co-authored-by: Nicolas Agustin Guevara Pihen <[email protected]>
Co-authored-by: Antonio <[email protected]>
yenienserrano added a commit that referenced this pull request Oct 28, 2024
@yenienserrano @AlexRuiz7
@Machi3mfl @Tostti @Desvelao
Compatibility with OpenSearch 2.11.1 (#131)
13caebb 
Signed-off-by: yenienserrano <[email protected]>
Signed-off-by: Álex Ruiz <[email protected]>
Signed-off-by: Ian Yenien Serrano <[email protected]>
Co-authored-by: Álex Ruiz <[email protected]>
Co-authored-by: Maximiliano Ibarra <[email protected]>
Co-authored-by: Nicolas Agustin Guevara Pihen <[email protected]>
Co-authored-by: Antonio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tostti Tostti Tostti approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compatibility with OpenSearch 2.11.1
4 participants
@yenienserrano @codecov-commenter @Tostti @AlexRuiz7