-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add frontend serverSecurity service #7026
Open
Desvelao
wants to merge
28
commits into
master
Choose a base branch
from
enhancement/6959-extract-common-services-frontend-server-security
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add frontend serverSecurity service #7026
Desvelao
wants to merge
28
commits into
master
from
enhancement/6959-extract-common-services-frontend-server-security
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create basic types - Create CoreServerSecurity implementation - Create runtime dependencies of serverSecurity - hooks - useServerUserLogged, - useServerUserPermissions, - useServerUserPermissionsRequirements, - useServerUserPermissionsIsAdminRequirements, - hocs - withServerUserAuthorizationPrompt, - withServerUserLogged, - ui - ServerButtonPermissions - ServerElementPermissions - Export the serverSecurity service in the lifecycle methods of core plugin
6 tasks
6 tasks
plugins/wazuh-core/public/services/server-security/wz-user-permissions.ts
Outdated
Show resolved
Hide resolved
plugins/wazuh-core/public/services/server-security/ui/hocs/creator.tsx
Outdated
Show resolved
Hide resolved
plugins/wazuh-core/public/services/server-security/ui/hocs/creator.tsx
Outdated
Show resolved
Hide resolved
plugins/wazuh-core/public/services/server-security/ui/hocs/creator.tsx
Outdated
Show resolved
Hide resolved
plugins/wazuh-core/public/services/server-security/ui/hocs/creator.tsx
Outdated
Show resolved
Hide resolved
plugins/wazuh-core/public/services/server-security/ui/components/format.tsx
Outdated
Show resolved
Hide resolved
plugins/wazuh-core/public/services/server-security/ui/components/format.tsx
Outdated
Show resolved
Hide resolved
plugins/wazuh-core/public/services/server-security/ui/components/format.tsx
Outdated
Show resolved
Hide resolved
plugins/wazuh-core/public/services/server-security/ui/components/button.tsx
Outdated
Show resolved
Hide resolved
plugins/wazuh-core/public/services/server-security/ui/components/button.tsx
Outdated
Show resolved
Hide resolved
plugins/wazuh-core/public/services/server-security/ui/components/button.tsx
Outdated
Show resolved
Hide resolved
plugins/wazuh-core/public/services/server-security/ui/components/button.tsx
Outdated
Show resolved
Hide resolved
plugins/wazuh-core/public/services/server-security/ui/components/button.tsx
Outdated
Show resolved
Hide resolved
plugins/wazuh-core/public/services/server-security/ui/components/element.tsx
Show resolved
Hide resolved
Co-authored-by: Guido Modarelli <[email protected]>
…to enhancement/6959-extract-common-services-frontend-server-security
Co-authored-by: Guido Modarelli <[email protected]>
…to enhancement/6959-extract-common-services-frontend-server-security
…rontend-server-security
…like the loading platform render
- move user authentication data to serverSecurity service - move user account data to dashboardSecurity service - move useServerUserPermissionsIsAdminRequirements from serverSecurity to useDashboardSecurityIsAdmin in dashboardSecurity service - add useDashboardSecurityAccount in dashboardSecurity service - fix documentation of http service
… loading component
guidomodarelli
requested changes
Dec 20, 2024
plugins/wazuh-core/public/services/server-security/ui/components/button.tsx
Outdated
Show resolved
Hide resolved
plugins/wazuh-core/public/services/server-security/ui/components/format.tsx
Show resolved
Hide resolved
plugins/wazuh-core/public/services/server-security/ui/components/format.tsx
Show resolved
Hide resolved
plugins/wazuh-core/public/services/server-security/wz-user-permissions.ts
Outdated
Show resolved
Hide resolved
plugins/wazuh-core/public/services/dashboard-security/README.md
Outdated
Show resolved
Hide resolved
plugins/wazuh-core/public/services/dashboard-security/dashboard-security.ts
Outdated
Show resolved
Hide resolved
plugins/wazuh-core/public/services/dashboard-security/dashboard-security.ts
Outdated
Show resolved
Hide resolved
guidomodarelli
previously approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yenienserrano
approved these changes
Dec 20, 2024
guidomodarelli
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a
serverSecurity
client to thewazuh-core
plugin and expose it to manage the security of the Wazuh server is a composition of old services:Changes:
Screenshot
dashboardSecurity
servicedashboardSecurity
andserverSecurity
servicesdashboardSecurity
serviceIssues Resolved
#6959
Test
Check List
yarn test:jest