Test Fixed, change decoder/rule tittle for correct execution #4496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR Tested on |
mauceballos
approved these changes
Sep 12, 2022
Mayons95
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Sep 12, 2022
* Test Fixed, change decoder tittle for correct execution * Adding random name based on timestamp * Add new writing behaviour, same as decoder (cherry picked from commit ec3e4f6)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 12, 2022
* Test Fixed, change decoder tittle for correct execution * Adding random name based on timestamp * Add new writing behaviour, same as decoder (cherry picked from commit ec3e4f6)
Mayons95
added a commit
that referenced
this pull request
Sep 12, 2022
…t execution (#4497) Test Fixed, change decoder/rule tittle for correct execution (#4496) * Test Fixed, change decoder tittle for correct execution * Adding random name based on timestamp * Add new writing behaviour, same as decoder (cherry picked from commit ec3e4f6) Co-authored-by: Mayons95 <[email protected]>
Mayons95
added a commit
that referenced
this pull request
Sep 12, 2022
…rect execution (#4498) Test Fixed, change decoder/rule tittle for correct execution (#4496) * Test Fixed, change decoder tittle for correct execution * Adding random name based on timestamp * Add new writing behaviour, same as decoder (cherry picked from commit ec3e4f6) Co-authored-by: Mayons95 <[email protected]>
18 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements a fix to Create new decoder/rule test for Wazuh Dashboard.
The main problem is related to the decoder name, the new decoder needs to have a unique name
Solution:
The proposed solution is to use a random name for the new decoders based on the timestamp. I add this code in a new function in the controller so we can implement it in other test cases as well.
E2E tests