-
Notifications
You must be signed in to change notification settings - Fork 187
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Redesign add page] Add form status callout message (#5634)
* Add form status manager and unit tests * Add empty and invalid fields messages * Hide commands code block when exists warning messages * Fix fields names in warning messages * Updated CHANGELOG
- Loading branch information
Showing
5 changed files
with
392 additions
and
33 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
145 changes: 145 additions & 0 deletions
145
plugins/main/public/controllers/register-agent/services/form-status-manager.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,145 @@ | ||
| import { | ||
| EnhancedFieldConfiguration, | ||
| UseFormReturn, | ||
| } from '../../../components/common/form/types'; | ||
| import { | ||
| FormStepsDependencies, | ||
| RegisterAgentFormStatusManager, | ||
| } from './form-status-manager'; | ||
|
|
||
| const defaultFormFieldData: EnhancedFieldConfiguration = { | ||
| changed: true, | ||
| value: 'value1', | ||
| error: '', | ||
| currentValue: '', | ||
| initialValue: '', | ||
| type: 'text', | ||
| onChange: () => { | ||
| console.log('onChange'); | ||
| }, | ||
| setInputRef: () => { | ||
| console.log('setInputRef'); | ||
| }, | ||
| inputRef: null, | ||
| }; | ||
|
|
||
| const formFieldsDefault: UseFormReturn['fields'] = { | ||
| field1: { | ||
| ...defaultFormFieldData, | ||
| value: '', | ||
| error: null, | ||
| }, | ||
| field2: { | ||
| ...defaultFormFieldData, | ||
| value: '', | ||
| error: 'error message', | ||
| }, | ||
| field3: { | ||
| ...defaultFormFieldData, | ||
| value: 'value valid', | ||
| error: null, | ||
| }, | ||
| }; | ||
|
|
||
| describe('RegisterAgentFormStatusManager', () => { | ||
| it('should create a instance', () => { | ||
| const registerAgentFormStatusManager = new RegisterAgentFormStatusManager( | ||
| formFieldsDefault, | ||
| ); | ||
| expect(registerAgentFormStatusManager).toBeDefined(); | ||
| }); | ||
|
|
||
| it('should return the form status', () => { | ||
| const registerAgentFormStatusManager = new RegisterAgentFormStatusManager( | ||
| formFieldsDefault, | ||
| ); | ||
| const formStatus = registerAgentFormStatusManager.getFormStatus(); | ||
| expect(formStatus).toEqual({ | ||
| field1: 'empty', | ||
| field2: 'invalid', | ||
| field3: 'complete', | ||
| }); | ||
| }); | ||
|
|
||
| it('should return the field status', () => { | ||
| const registerAgentFormStatusManager = new RegisterAgentFormStatusManager( | ||
| formFieldsDefault, | ||
| ); | ||
| const fieldStatus = registerAgentFormStatusManager.getFieldStatus('field1'); | ||
| expect(fieldStatus).toEqual('empty'); | ||
| }); | ||
|
|
||
| it('should return error if fieldname not found', () => { | ||
| const registerAgentFormStatusManager = new RegisterAgentFormStatusManager( | ||
| formFieldsDefault, | ||
| ); | ||
| expect(() => | ||
| registerAgentFormStatusManager.getFieldStatus('field4'), | ||
| ).toThrowError('Fieldname not found'); | ||
| }); | ||
|
|
||
| it('should return a INVALID when the step have an error', () => { | ||
| const formSteps: FormStepsDependencies = { | ||
| step1: ['field1', 'field2'], | ||
| step2: ['field3'], | ||
| }; | ||
| const registerAgentFormStatusManager = new RegisterAgentFormStatusManager( | ||
| formFieldsDefault, | ||
| formSteps, | ||
| ); | ||
| expect(registerAgentFormStatusManager).toBeDefined(); | ||
| expect(registerAgentFormStatusManager.getStepStatus('step1')).toEqual( | ||
| 'invalid', | ||
| ); | ||
| }); | ||
|
|
||
| it('should return COMPLETE when the step have no errors and is not empty', () => { | ||
| const formSteps: FormStepsDependencies = { | ||
| step1: ['field1', 'field2'], | ||
| step2: ['field3'], | ||
| }; | ||
| const registerAgentFormStatusManager = new RegisterAgentFormStatusManager( | ||
| formFieldsDefault, | ||
| formSteps, | ||
| ); | ||
| expect(registerAgentFormStatusManager).toBeDefined(); | ||
| expect(registerAgentFormStatusManager.getStepStatus('step2')).toEqual( | ||
| 'complete', | ||
| ); | ||
| }); | ||
|
|
||
| it('should return EMPTY when the step all fields empty', () => { | ||
| const formSteps: FormStepsDependencies = { | ||
| step1: ['field1'], | ||
| step2: [ 'field2', | ||
| 'field3' ], | ||
| }; | ||
| const registerAgentFormStatusManager = new RegisterAgentFormStatusManager( | ||
| formFieldsDefault, | ||
| formSteps, | ||
| ); | ||
| expect(registerAgentFormStatusManager).toBeDefined(); | ||
| expect(registerAgentFormStatusManager.getStepStatus('step1')).toEqual( | ||
| 'empty', | ||
| ); | ||
| }); | ||
|
|
||
| it('should return all the steps status', () => { | ||
| const formSteps: FormStepsDependencies = { | ||
| step1: ['field1'], | ||
| step2: [ 'field2', | ||
| 'field3' ], | ||
| step3: ['field3'] | ||
| }; | ||
| const registerAgentFormStatusManager = new RegisterAgentFormStatusManager( | ||
| formFieldsDefault, | ||
| formSteps, | ||
| ); | ||
| expect(registerAgentFormStatusManager).toBeDefined(); | ||
| expect(registerAgentFormStatusManager.getFormStepsStatus()).toEqual({ | ||
| step1: 'empty', | ||
| step2: 'invalid', | ||
| step3: 'complete' | ||
| }); | ||
| }); | ||
| }); |
Oops, something went wrong.