Use a unique database manager and integrate it with the queue #496
+2,001
−1,898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
TomasTurina
force-pushed
the
enhancement/122-unify-sqlite-manager
branch
from
72f35ac to
2092181
Compare
LucioDonda
reviewed
Jan 10, 2025
| { | ||
| queryFields.emplace_back(query.getColumn(i).getName(), | ||
| ColumnTypeFromSQLiteType(query.getColumn(i).getType()), | ||
| query.getColumn(i).getString()); |
There was a problem hiding this comment.
What if the value is not a string?
Comment on lines
+85
to
+87
| ColumnValue(std::string name, const ColumnType type, std::string value) | ||
| : ColumnName(std::move(name), type) | ||
| , Value(std::move(value)) |
There was a problem hiding this comment.
Type can be TEXT INTEGER or REAL but while constructing ColumValue it only accepts string. Can this be an issue?
TomasTurina
force-pushed
the
enhancement/122-unify-sqlite-manager
branch
from
ed2e1f6 to
ffd8732
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP
Tests