Storage notifications #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoiseiev
reviewed
Jan 31, 2018
| name = "default_topic" | ||
| } | ||
|
|
||
| //GCS default storage account must have "projects.topics.publish" permission |
There was a problem hiding this comment.
can we refer to Google's docs here? And a specific example of this special account will greatly help here. Is it @gs-project-accounts.iam.gserviceaccount.com?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for GSC Notifications issue 971
API reference here
The resource closely mimics the API functionality. if no event_types are passed, ALL events will be publishing to pubsub topic. If event_types are passed, only specific events will be published
Confirmed that creating notifications actually catches the events by creating a subscription and pulling from it.