ref: Accept client-side wayland connection, global #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shinyzenith <[email protected]>
| // this anymore | ||
|
|
||
| let mut state = state::WaysipState::new(kind); | ||
| pub fn get_area( |
There was a problem hiding this comment.
I think the origin api should be reserved.Sometimes I do not want to induce wayland-client
There was a problem hiding this comment.
maybe add like get_area_with_connection like this kind , maybe add one extra function will be better I think.
There was a problem hiding this comment.
or make connection and globals optional I think will be better. if it is none, make a new connection and globals
like create a struct
WaysipWaylandInfo<'a> {
globals: GlobalList,
connection: &'a Connection
}
|
I would perfer like this |
|
Looks good, would you want me to merge your pr or edit it into mine? |
|
Maybe committing to my branch |
|
ok, if that pr is ok, can you merge mime? |
|
sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clients should be able to provide their own connection and global list instead of wasting time on another roundtrip / causing a segfault due to two open wayland-connections