Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for subtypes #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wesleytodd
Copy link

So this is much bigger than I imagined. There were quite a few things that changed because I moved the functionality for name parsing and construction more into multicast-dns-service-types, which this PR required to run (https://github.com/wesleytodd/multicast-dns-service-types/tree/v2.0.0).

Also, while all of the tests pass, I had to change some of the values in them. They where all pretty much what looked like internal use only variables. Let me know if I am mistaken.

I haven't yet tested it with my little project, I will update this when I have, but I figured I would post it to get feedback first. I can also probably test out your ipp project to for compatibility (hopefully this wont break anything), but might not be able to for a few days.

Let me know what you think!

@wesleytodd
Copy link
Author

Probably should have been sure I was up-to-date before doing this. Will fix the conflicts and update.

@wesleytodd
Copy link
Author

well i thought that might work on travis, but i guess not. If you clone it down though it should pass :)

@jspiro
Copy link

jspiro commented Sep 2, 2016

Hope to see this integrated someday :)

@wesleytodd
Copy link
Author

@jspiro I obviously took a hiatus on this project....paying the bills and all that :)

But I think it is just pending work over here: mafintosh/multicast-dns-service-types#6

If you are interested in picking up where that left off it seems reasonable that this could get finished up. I unfortunately do not see me finishing this any time soon, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants