minor improvements #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! edit: awesome lib ! |
|
Thanks a lot for the pull request 😃 In the future it would have been better if you'd split this up into two separate PR's as the two commits have nothing to do with each other. That would make each easier to discuss. |
| var tout = opts.timeout && setTimeout(function () { | ||
| browser.emit('notfound') | ||
| browser.stop() | ||
| if (cb) cb(false) |
There was a problem hiding this comment.
I think it would make more sense to just call the callback without any arguments instead of false in case the timeout happens
|
@maboiteaspam ping 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an example file example.js which demonstrates more about the library
Changed
Bonjour.findOnemethod to addopts.timeoutsupport