Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File called "string" created on startup #56

Closed
cfjedimaster opened this issue Aug 5, 2015 · 12 comments
Closed

File called "string" created on startup #56

cfjedimaster opened this issue Aug 5, 2015 · 12 comments
Assignees
Labels

Comments

@cfjedimaster
Copy link

I noticed my node app was creating a file called "string" with the contents: testtest

I narrowed it down to the init portion of this library:

var visual_recognition = watson.visual_recognition({
username: 'stuff',
password: 'more stuff',
version: 'v1'
});

@germanattanasio germanattanasio self-assigned this Aug 5, 2015
@germanattanasio
Copy link
Contributor

@cfjedimaster We don't create files in the wrapper/library.
Are you using the sample app?

@cfjedimaster
Copy link
Author

Nope. I'm using this: https://github.com/cfjedimaster/IonicBluemixDemo

I basically commented out more and more of my app.js file and narrowed it down to that part.

@nfriedly
Copy link
Contributor

nfriedly commented Aug 5, 2015

So, I just made all fs.write* functions log a stack trace, and it looks like it's coming from this: https://github.com/jprichardson/string.js/blob/master/lib/string.js#L726 which is in one of the watson-developer-cloud dependencies. I'm not exactly sure what they're trying to do there, but I don't think they're doing it, so I'm going to file a bug on that repo and link to this one.

@cfjedimaster
Copy link
Author

Muchas gracias.

On Wed, Aug 5, 2015 at 1:06 PM, Nathan Friedly [email protected]
wrote:

So, I just made all fs.write* functions log a stack trace, and it looks
like it's coming from this:
https://github.com/jprichardson/string.js/blob/master/lib/string.js#L726
which is in one of the watson-developer-cloud dependencies. I'm not exactly
sure what they're trying to do there, but I don't think they're doing it,
so I'm going to file a bug on that repo and link to this one.


Reply to this email directly or view it on GitHub
#56 (comment)
.

Raymond Camden, Developer Advocate for MobileFirst at IBM

Email : [email protected]
Blog : www.raymondcamden.com
Twitter: raymondcamden

@germanattanasio
Copy link
Contributor

Thanks @nfriedly, lets keep this bug open until they fix it.

@jsstylos
Copy link
Contributor

jsstylos commented Aug 5, 2015

Nice debugging @nfriedly! Thanks for the report, @cfjedimaster.

@nfriedly
Copy link
Contributor

nfriedly commented Aug 5, 2015

BTW, since @jsstylos asked about it, this is the code to make all fs.write* methods log a stack trace: https://gist.github.com/nfriedly/5813c0fcea944f05ccfe

@nfriedly
Copy link
Contributor

nfriedly commented Aug 5, 2015

So, it looks like this is a bug in the interaction between shelljs and string.js - cfjedimaster/IonicBluemixDemo#1 has a simple workaround of just loading string.js first (you'll have to delete node_modules and reinstall though, I moved string.js to a top-tier dependency to make it work.)

@cfjedimaster
Copy link
Author

Wow, you certainly didn't need to file a PR to fix it for me on my side
too. Thank you. :)

On Wed, Aug 5, 2015 at 1:40 PM, Nathan Friedly [email protected]
wrote:

So, it looks like this is a bug in the interaction between shelljs and
string.js - cfjedimaster/IonicBluemixDemo#1
cfjedimaster/IonicBluemixDemo#1 has a simple
workaround of just loading string.js first (you'll have to delete
node_modules and reinstall though, I moved string.js to a top-tier
dependency to make it work.)


Reply to this email directly or view it on GitHub
#56 (comment)
.

Raymond Camden, Developer Advocate for MobileFirst at IBM

Email : [email protected]
Blog : www.raymondcamden.com
Twitter: raymondcamden

@nfriedly
Copy link
Contributor

nfriedly commented Aug 5, 2015

Yea, it looks like they're adding a workaround to string.js so you can just ignore that PR. I mostly did it to see if that was indeed the issue. And then since I already did the work, I figured I might as well make it available ;)

@az7arul
Copy link
Contributor

az7arul commented Aug 5, 2015

@germanattanasio its fixed in 3.3.1 of string.js

az7arul added a commit to az7arul/nodejs-wrapper that referenced this issue Aug 5, 2015
az7arul added a commit to az7arul/nodejs-wrapper that referenced this issue Aug 5, 2015
nfriedly added a commit that referenced this issue Aug 5, 2015
update string.js version to fix #56
@germanattanasio
Copy link
Contributor

thanks @az7arul!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

5 participants