querystring: fix state machine in querystring.parse

- posIdx should save the current position instead of the last position. Fixed cases: - `a&&b` => `{ 'a': '', 'b': '' }` - `a=a&&b=b` => `{ 'a': 'a', 'b': 'b' }` Fixes nodejs#10454
watilde · Feb 4, 2017 · a6d3530 · a6d3530
1 parent 8b04bc9
commit a6d3530
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/querystring.js b/lib/querystring.js
@@ -347,7 +347,7 @@ function parse(qs, sep, eq, options) {
         keyEncoded = valEncoded = customDecode;
         encodeCheck = 0;
         key = value = '';
-        posIdx = lastPos;
+        posIdx = i;
         lastPos = i + 1;
         sepIdx = eqIdx = 0;
       }

diff --git a/test/parallel/test-querystring.js b/test/parallel/test-querystring.js
@@ -59,6 +59,8 @@ const qsTestCases = [
   ['&&&&', '', {}],
   ['&=&', '=', { '': '' }],
   ['&=&=', '=&=', { '': [ '', '' ]}],
+  ['a&&b', 'a=&b=', { 'a': '', 'b': '' }],
+  ['a=a&&b=b', 'a=a&b=b', { 'a': 'a', 'b': 'b' }],
   [null, '', {}],
   [undefined, '', {}]
 ];