Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repalced js-loading-overlay to pure css to show loader. #301

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

JinIgarashi
Copy link
Member

Thank you for submitting a pull request!

Description

because of js-loading-overlay, it causes problem of importing package in SSR mode. I replaced it with pure css to show simple loader.

Plugin

Select a plugin related to this PR.

  • maplibre-gl-export
  • mapbox-gl-export

Type of Pull Request

  • Adding a feature
  • Fixing a bug
  • Maintaining documents
  • Others ()

Verify the followings

  • Code is up-to-date with the main branch
  • No lint errors after pnpm lint
  • Make sure all the existing features working well
  • Make sure a changeset file is added if your PR changes package code

Refer to CONTRIBUTING.MD for more details.

@JinIgarashi JinIgarashi added the bug Something isn't working label Nov 13, 2024
Copy link

changeset-bot bot commented Nov 13, 2024

🦋 Changeset detected

Latest commit: 6af2e51

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@watergis/maplibre-gl-export Patch
@watergis/mapbox-gl-export Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for maplibre-gl-export ready!

Name Link
🔨 Latest commit 6af2e51
🔍 Latest deploy log https://app.netlify.com/sites/maplibre-gl-export/deploys/6734502ac677a000084e5a2b
😎 Deploy Preview https://deploy-preview-301--maplibre-gl-export.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JinIgarashi JinIgarashi merged commit c3c5f8c into main Nov 13, 2024
5 checks passed
@JinIgarashi JinIgarashi deleted the fix/css-loader branch November 13, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant