Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eslint setting #26

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Fix eslint setting #26

merged 1 commit into from
Oct 25, 2022

Conversation

YuChunTsao
Copy link
Contributor

Description

About #25 (comment)

  • Find and fix *.ts in lib.
  • Add new rule about type-annotation-spacing
  • Fix eslint error problems

Type of Pull Request

  • Fixing a bug

Verify the followings

  • Code is up-to-date with the main branch
  • No lint errors after yarn run lint
  • Make sure all the exsiting features working well

Refer to CONTRIBUTING.MD for more details.

@YuChunTsao
Fix eslint setting
161c38b 
- Find and fix *.ts in lib.
- Add new rule about type-annotation-spacing
- Fix eslint error problems
@JinIgarashi JinIgarashi added the bug Something isn't working label Oct 25, 2022
@JinIgarashi JinIgarashi merged commit 59898aa into watergis:main Oct 25, 2022
@JinIgarashi
Copy link
Member

@YuChunTsao Thanks a lot for fixing lint bug.

@YuChunTsao YuChunTsao deleted the fix-eslint-setting branch October 25, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JinIgarashi JinIgarashi JinIgarashi approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuChunTsao @JinIgarashi