Fix week converion issue in cron syntax. (#70)

wata727 · Jan 27, 2024 · abe86cc · abe86cc
1 parent 5b57ee6
commit abe86cc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/elastic_whenever/schedule.rb b/lib/elastic_whenever/schedule.rb
@@ -136,7 +136,7 @@ def schedule_expression(frequency, options)
         day.gsub!("*", "?") if week != "?"
         # cron syntax:          sunday -> 0
         # scheduled expression: sunday -> 1
-        week.gsub!(/(\d)/) { (Integer($1) + 1) % 7 }
+        week.gsub!(/(\d)/) { Integer($1) + 1 }
         year = year || "*"
         "cron(#{min} #{hour} #{day} #{mon} #{week} #{year})"
       # schedule expression syntax

diff --git a/spec/schedule_spec.rb b/spec/schedule_spec.rb
@@ -290,7 +290,7 @@
     end
 
     it "converts from cron syntax specified week" do
-      expect(schedule.schedule_expression("0 0 * * 0", {})).to eq "cron(0 0 ? * 1 *)"
+      expect(schedule.schedule_expression("0 0 * * 0,1,2,3,4,5,6", {})).to eq "cron(0 0 ? * 1,2,3,4,5,6,7 *)"
     end
 
     it "converts from day shortcuts" do