Post 0.16.0 cleanup #2490
Open
Post 0.16.0 cleanup #2490
+90
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infomiho
approved these changes
Feb 7, 2025
|
@infomiho Sorry, should have marked this one as Draft as it's still WIP. I'll ping you for another review :) |
sodic
commented
Feb 12, 2025
There was a problem hiding this comment.
This got moved from SdkGenerator.Server.Operations, nothing new here.
sodic
commented
Feb 12, 2025
Comment on lines
+20
to
+21
| # apps for testing | ||
| examples/ignored |
There was a problem hiding this comment.
I sneaked this in because I like to have experimental apps in the scope of cabal run wasp-cli but I don't like them polluting my commit history.
sodic
commented
Feb 12, 2025
Comment on lines
+41
to
+44
| return $ left ((errorMessagePrefix ++) . indent 2) parseResult | ||
| where | ||
| errorMessagePrefix = "Failed to parse '" ++ baseTsConfigFilePath ++ "':\n" | ||
| baseTsConfigFilePath = fromRelFile (basename tsConfigFile) |
There was a problem hiding this comment.
With the indent and the new line, the message looks like this:
❌ --- [Error] Analyzing wasp project failed: -------------------------------------
1 errors found:
- Failed to parse 'tsconfig.json':
[eval]:15
"composite": true,
^^^^^^^^^^^
SyntaxError: Unexpected string
at makeContextifyScript (node:internal/vm:122:14)
at node:internal/process/execution:89:22
at [eval]-wrapper:6:24
at runScript (node:internal/process/execution:83:62)
at evalScript (node:internal/process/execution:114:10)
at node:internal/main/eval_string:30:3
Node.js v18.20.4
Without them, it looks broken:
❌ --- [Error] Analyzing wasp project failed: -------------------------------------
1 errors found:
- Failed to parse 'tsconfig.json': [eval]:15
"composite": true,
^^^^^^^^^^^
SyntaxError: Unexpected string
at makeContextifyScript (node:internal/vm:122:14)
at node:internal/process/execution:89:22
at [eval]-wrapper:6:24
at runScript (node:internal/process/execution:83:62)
at evalScript (node:internal/process/execution:114:10)
at node:internal/main/eval_string:30:3
Node.js v18.20.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.